Photo delete endpoint on Node API

[pisum]

@rcloran

deleting an observation_photo did not

i haven’t tested in a while, but my note from https://forum.inaturalist.org/t/is-it-possible-to-use-the-api-to-attach-an-existing-photo-record-to-an-observation/29814/9 seems to indicate that photo records will be deleted:

@pisum

the list of photoIDs must include all photos that need to be included in the observation, including photos already attached to the observation. (for example, if obs A includes photos X and Y, and you want to add Z, then list of photos in your PUT must be [X,Y,Z].

• if you do not include a photo in the list, it will be dropped from the observation, and photos that dropped from the observation and are not tied to any other observations will be immediately deleted. (for example, if obs A includes photos X and Y, which are tied only to A, and you PUT only [Z], obs A will end up with only Z, and X and Y will be gone. in other words, you need to be careful about accidentally orphaning photos, since orphans are immediately purged.)

…

also, here’s the other thing i mentioned earlier related to image files not getting properly deleted even if the photo records are: https://forum.inaturalist.org/t/image-files-stored-on-media-server-dont-seem-to-be-getting-deleted-when-observations-and-photo-records-are-getting-deleted/36460.