24-hour clock time notation should not include AM/PM

Bug Reports
1

Platform: Website
Browser: Chrome

URLs (aka web addresses) of any relevant observations or pages: https://www.inaturalist.org/home

Description of problem: The displayed time in the /home page - e.g. for last forum post or for last observation update - is shown using 24-hour clock notation according to my time and locale settings in inaturalist (GMT+01:00 Copenhagen / Danish). But the notation also includes AM and PM which is used in 12-hour clock time notation (furthermore the “AM” seems to be erroneously translated to “ER” - but I am aware that translation errors are handled elsewhere).

image
image486×567 28.2 KB

If I look at the times displayed in my observation list (https://www.inaturalist.org/observations/jensgc) it shows that these times are displayed in 12-hour clock notation - using the correct timezone and AM/PM shown as expected in 12-hour notation.

If the site was correctly localized I would expect all times shown using 24-hour clock notation as follows:

Date value (ISO)				Expected format (Danish)		Current format
2020-09-02T15:02:22+02:00		15:02 							15:02 PM
2020-09-02T09:29:23+02:00		09:29							09:29 ER
2020-09-02T12:14:00+02:00		2. september 2020 kl. 12:14		02. September, 2020 12:14 
PM CEST
2020-08-30T16:25:00+02:00		30. august 2020 kl. 16:25 		30. august, 2020 04:25 PM CEST
8 Likes
2

I’ll add this to my weekly report.

2 Likes
3

Here’s what I wrote in the discussion on Crowdin: the am string is at https://crowdin.com/translate/inaturalistweb/38/en-da#24500. I just changed it from “er” to “am.” Since Crowdin says I added it a year ago, I think that means it originally came from Translatewiki. Definitely a tough one to translate without much context.

Regarding the formatting the dates on the Forum widget on the dashboard, that’s using https://crowdin.com/translate/inaturalistweb/38/en-da#24508 when the date is today and it shows the time. Note the use of %p there, which I’m guessing should be omitted.

2 Likes
4

Looks to be working now.

5

I thought the issue was not that AM was being mis-translated, but that AM/PM were showing up at all when the time was in 24 hour notation. It should be 09:29 or 15:32, not 09:29 AM or 15:32 PM.

6

Here’s what I see now, when I switch my locale to Danish:

image
image918×878 51.8 KB

7

Hmmm, I’m still seeing AMs and PMs (locale English) after refreshing the page. So I guess 12 hour notation is the only option for that locale?