Taxon change banner showing on page where it's not necessary

[mustermark]

Platform: Website

URLs: https://www.inaturalist.org/taxa/47663-Maxillopoda

Screenshots of what you are seeing:

Description of problem

On https://www.inaturalist.org/taxa/47663-Maxillopoda, it says “Heads up: this taxon concept is inactive. Maxilopoda [372744] was replaced by Maxillopoda [47663]. View Taxon Change” and it is marked as an inactive taxon.

If 372744 was replaced by 47633, then why is 47633 marked as inactive. Unless that was replaced by something else, in which case why doesn’t it say so?

[adamjroberts]

If I understand correctly…

@mustermark

why is 47633 marked as inactive

Per WoRMS: “Maxillopoda is no longer recognised as a valid monophyletic taxon. Its component groups are divided between Oligostraca and Multicrustacea.”

@mustermark

why doesn’t it say so?

The dividing up of Maxillopoda wouldn’t have been a single taxon change like a swap or a split. Its subtaxa would have been regrafted into Multicrustacea and Oligostraca. Once that had all been done, Maxillopoda would have been empty. The last step would then have been to mark it inactive.

But from what I can see/guess, I think you’re right that that particular message should only be showing on 372744, not also on 47663. Both taxa are correctly inactive, but only 372744 is inactive because of the swap the message is referring to.

[mustermark]

Yep, that makes sense. As you say, the message should only be showing on 372744. I see the page makes a request to https://www.inaturalist.org/taxon_changes.json?taxon_id=47663 which returns the taxon swap as follows:

[{
    "id":9918,
    "description":"Synonym",
    "taxon_id":47663,
    "source_id":null,
    "user_id":477,"
    created_at":"2014-12-16T01:02:36.659+00:00",
    "updated_at":"2014-12-16T01:02:43.514+00:00",
    "committed_on":"2014-12-16",
    "change_group":"",
    "committer_id":477,
    "move_children":true,
    "type":"TaxonSwap",
    "input_taxa":[{"id":372744,"name":"Maxilopoda","rank":"class"}],
    "output_taxa":[{"id":47663,"name":"Maxillopoda","rank":"class"}]
}]

I suppose the response might be correct because the URL doesn’t specify that is querying taxon changes where the given taxon was necessarily the input taxon, but the front end should only present the taxon swap as a reason for the taxon being inactive if the taxon is the input taxa of the taxon swap.

[tiwane]

Made a github issue here: https://github.com/inaturalist/inaturalist/issues/3825

[tiwane]

Fixed.